Adding Host Based NFS for Powerstore #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuluna
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
donatwork and
santhoshatdell
as code owners
lukeatdell
reviewed
Mar 26, 2025
falfaroc
requested changes
Mar 27, 2025
| VolumeCapability: &csi.VolumeCapability{ | ||
| AccessType: &csi.VolumeCapability_Mount{ | ||
| Mount: &csi.VolumeCapability_MountVolume{ | ||
| MountFlags: []string{"rw"}, |
There was a problem hiding this comment.
question: Should this be configurable?
There was a problem hiding this comment.
I think @bharathsreekanth is looking into the permission here to be configurable, and needs confirmation from PM?
lukeatdell
previously approved these changes
Mar 28, 2025
falfaroc
previously approved these changes
Mar 28, 2025
falfaroc
previously approved these changes
Mar 31, 2025
abhi16394
previously approved these changes
Mar 31, 2025
falfaroc
reviewed
Apr 1, 2025
|
@xuluna Do not merge this before I merge my PR onto this branch. Please. |
| # Optional: false | ||
| # Default value: None | ||
| arrayID: globalID | ||
| csi-nfs: RWX |
There was a problem hiding this comment.
Question: Does this override the accessMode provided in PVC ?
To enhance clarity, it might be helpful to consider using a more descriptive name, such as csi-nfs-accessMode: RWX
There was a problem hiding this comment.
It doesn't change the access mode of the pvc. Just for the NFS export.
abhi16394
approved these changes
Apr 1, 2025
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
lukeatdell
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding host based NFS feature for Powerstore.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration