Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prereq.sh to fix bug report #2356. Make the rpm based installa… #2357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nthorne-dell
Copy link

Issues Resolved by this Pull Request

#2356

Fixes #

Description of the Solution

Please describe the solution provided and how it resolves the associated issues.

Suggested Reviewers

If you wish to suggest specific reviewers for this solution, please include them in this section. Be sure to include the @ before the GitHub username.

…allation block look the same as the apt one above it by instaling 2 packages instead of just python39.
@dweineha
Copy link

lgtm.

Copy link

@dweineha dweineha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installs an extra package and removes a superfluous newline. Seems obviously correct.

@abhishek-sa1
Copy link
Contributor

@nthorne-dell Omnia does not support rocky 9.3

@Aditya-DP
Copy link
Collaborator

run omnia-checkers

@Omnia-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@lwilson
Copy link
Collaborator

lwilson commented Feb 5, 2025

@abhishek-sa1 let's not ignore PRs just because we don't offer support for a particular OS version. This seems like it was an obvious, non-breaking fix. We should be able to accept these types of changes.

@abhishek-sa1
Copy link
Contributor

@lwilson Its not only due to OS support, currently omnia support python3.11 in latest version and already necessary changes made with respect to new flow. It handles installing pip packages as well. Please refer screenshot below.

image

File - https://github.com/dell/omnia/blob/main/prereq.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants