Skip to content

List issues #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 14, 2025
Merged

List issues #292

merged 14 commits into from
Apr 14, 2025

Conversation

rounak-adhikary
Copy link
Contributor

@rounak-adhikary rounak-adhikary commented Apr 8, 2025 •
edited
Loading

Description

Fixing bugs introduced in #281 because of writing plan to state for list types.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/dell-terraform-providers#23

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE NAMEs

ADS provider
network pool

OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@rounak-adhikary rounak-adhikary marked this pull request as ready for review April 9, 2025 07:09
@shenda1
Copy link
Contributor

shenda1 commented Apr 11, 2025

@rounak-adhikary LGTM. Can we run AT/UTs for the modified resources?

@rounak-adhikary
Copy link
Contributor Author

@shenda1 UTs/ATs are all passing except the mocked TestSession tests, which are unrelated to my changes.

@rounak-adhikary rounak-adhikary merged commit 6506d68 into main Apr 14, 2025
7 checks passed
@rounak-adhikary rounak-adhikary deleted the list-issues branch April 14, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenda1 shenda1 shenda1 approved these changes

@Sakshi-dell Sakshi-dell Sakshi-dell approved these changes

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@doriac11 doriac11 Awaiting requested review from doriac11 doriac11 is a code owner

@varunchinta varunchinta Awaiting requested review from varunchinta varunchinta is a code owner

@nikitajoshi1 nikitajoshi1 Awaiting requested review from nikitajoshi1 nikitajoshi1 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

@vangork vangork Awaiting requested review from vangork vangork is a code owner

@sapana05 sapana05 Awaiting requested review from sapana05 sapana05 is a code owner

@MangirishK MangirishK Awaiting requested review from MangirishK MangirishK is a code owner

@Krunal-Thakkar Krunal-Thakkar Awaiting requested review from Krunal-Thakkar Krunal-Thakkar is a code owner

@Krishnan-Priyanshu Krishnan-Priyanshu Awaiting requested review from Krishnan-Priyanshu

@AnikaAgiwal2711 AnikaAgiwal2711 Awaiting requested review from AnikaAgiwal2711

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rounak-adhikary @shenda1 @Sakshi-dell