Skip to content

added a new attribute sid to fetch the user details using sid #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025

Conversation

AnikaAgiwal2711
Copy link
Contributor

@AnikaAgiwal2711 AnikaAgiwal2711 commented Apr 14, 2025

Description

This is related to the issue where a user is not able to create filesystems using sid.
I've added an attribute sid to the user datasource, so that now user can get the uid using sid and then use that uid in the fileystem to create it.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
RESOURCE OR DATASOURCE NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Acceptance tests

image

Copy link
Contributor

@rounak-adhikary rounak-adhikary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we need to add tests (mocked tests should do fine).

Copy link
Contributor

@rounak-adhikary rounak-adhikary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like coverage will not be affected by the acceptance tests.

@AnikaAgiwal2711 AnikaAgiwal2711 merged commit 7a8514b into main Apr 16, 2025
7 checks passed
@AnikaAgiwal2711 AnikaAgiwal2711 deleted the usr/anika/fs-github-issue branch April 16, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants