Skip to content

adding validation while adding members in role resource #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025

Conversation

shenda1
Copy link
Contributor

@shenda1 shenda1 commented Apr 18, 2025

Description

PR is raised to add validation to the role resource

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE OR DATASOURCE NAME

role resource

OUTPUT

# Checklist:

- [x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
- [x] I have verified that new and existing unit tests pass locally with my changes
- [ ] I have not allowed coverage numbers to degenerate
- [x] I have maintained at least 80% code coverage
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have maintained backward compatibility


# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

- [ ] Unit tests
- [ ] Acceptance tests

![image](https://github.com/user-attachments/assets/ccb03bd2-10ac-4db5-85d8-faaabf41d7fe)


@shenda1
Copy link
Contributor Author

shenda1 commented Apr 18, 2025

image

Signed-off-by: shenda1 <[email protected]>
Copy link
Contributor

@rounak-adhikary rounak-adhikary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenda1 shenda1 merged commit 8eb594e into main Apr 21, 2025
7 checks passed
@shenda1 shenda1 deleted the role-resource-validation branch April 21, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants