Skip to content

Commit

Permalink
Merge remote-tracking branch 'oss/main' into parsed-log-path
Browse files Browse the repository at this point in the history
  • Loading branch information
ryan-johnson-databricks committed Sep 23, 2024
2 parents 2f63a62 + 4c9a6ac commit 1453f9a
Show file tree
Hide file tree
Showing 4 changed files with 53 additions and 6 deletions.
26 changes: 26 additions & 0 deletions .github/workflows/auto-assign-issue.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Auto assign the issue via `take` comment

on:
issue_comment:
types: [created]

permissions:
issues: write

jobs:
auto-assign:
runs-on: ubuntu-latest
if: (!github.event.issue.pull_request) && github.event.comment.body == 'take'
concurrency:
# Only run one at a time for each user.
group: ${{ github.actor }}-issue-assign
steps:
- run: |
CODE=$(curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -LI https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/assignees/${{ github.event.comment.user.login }} -o /dev/null -w '%{http_code}\n' -s)
if [ "$CODE" -eq "204" ]
then
echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}"
curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -d '{"assignees": ["${{ github.event.comment.user.login }}"]}' https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/assignees
else
echo "Cannot assign issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}"
fi
25 changes: 25 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# How to contribute to Delta Kernel Rust

Welcome! We'd love to have you contribute to Delta Kernel Rust!

## Did you find a bug?

Create an issue with a reproducible example. Please specify the Rust version, delta-kernel-rs version, the code executed, and the error message.

## Did you create a PR to fix a bug?

Open a pull request and add "Fixes #issue_number" in the PR description.

We appreciate bug fixes - thank you in advance!

## Would you like to add a new feature or change existing code?

If you would like to add a feature or change existing behavior, please make sure to create an issue and get the planned work approved by the core team first!

Always better to get aligned with the core devs before writing any code.

## Do you have questions about the source code?

Feel free to create an issue or join the [Delta Lake Slack](https://go.delta.io/slack) with questions! We chat in the `#delta-kernel` channel.

Thanks for reading! :heart: :crab:
6 changes: 1 addition & 5 deletions kernel/src/scan/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -625,12 +625,8 @@ mod tests {
);
}

#[test]
#[test_log::test]
fn test_scan_data() {
use tracing_subscriber::EnvFilter;
tracing_subscriber::fmt()
.with_env_filter(EnvFilter::from_default_env())
.init();
let path =
std::fs::canonicalize(PathBuf::from("./tests/data/table-without-dv-small/")).unwrap();
let url = url::Url::from_directory_path(path).unwrap();
Expand Down
2 changes: 1 addition & 1 deletion kernel/src/snapshot.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl LogSegment {
use Expression as Expr;
let filter = Some(Expr::or(
Expr::not(Expr::is_null(Expr::column("metaData.id"))),
Expr::not(Expr::is_null(Expr::column("protocol.min_reader_version"))),
Expr::not(Expr::is_null(Expr::column("protocol.minReaderVersion"))),
));
// read the same protocol and metadata schema for both commits and checkpoints
let data_batches = self.replay(engine, schema.clone(), schema, filter)?;
Expand Down

0 comments on commit 1453f9a

Please sign in to comment.