Skip to content

Commit

Permalink
Address pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
OussamaSaoudi-db committed Oct 24, 2024
1 parent 984b615 commit 8530b8d
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions ffi/src/expressions/kernel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,11 @@ pub unsafe extern "C" fn visit_expression(
let child_value_list_id = call!(visitor, make_field_list, struct_data.fields().len());
let child_field_list_id = call!(visitor, make_field_list, struct_data.fields().len());
for (field, value) in struct_data.fields().iter().zip(struct_data.values()) {
visit_expression_scalar(
call!(
visitor,
&Scalar::String(field.name.clone()),
visit_string_literal,
child_field_list_id,
field.name().into()
);
visit_expression_scalar(visitor, value, child_value_list_id);
}
Expand All @@ -231,7 +232,7 @@ pub unsafe extern "C" fn visit_expression(
}
fn visit_expression_struct_expr(
visitor: &mut EngineExpressionVisitor,
exprs: &Vec<Expression>,
exprs: &[Expression],
sibling_list_id: usize,
) {
let child_list_id = call!(visitor, make_field_list, exprs.len());
Expand All @@ -243,7 +244,7 @@ pub unsafe extern "C" fn visit_expression(
fn visit_expression_variadic(
visitor: &mut EngineExpressionVisitor,
op: &VariadicOperator,
exprs: &Vec<Expression>,
exprs: &[Expression],
sibling_list_id: usize,
) {
let child_list_id = call!(visitor, make_field_list, exprs.len());
Expand Down

0 comments on commit 8530b8d

Please sign in to comment.