Skip to content

fix: preserve null bitmap in nested transform expressions #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrakeLin merged 1 commit into from
Jan 23, 2026
Merged

fix: preserve null bitmap in nested transform expressions #1645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions kernel/src/engine/arrow_expression/evaluate_expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,19 @@ fn evaluate_transform_expression(
}

// Extract the input path, if any
let source_data = transform
let source_array = transform
.input_path()
.map(|path| extract_column(batch, path))
.transpose()?;

let source_data: &dyn ProvidesColumnByName = match source_data {
// For nested transforms, get the source struct's null bitmap to preserve null rows
let source_null_buffer = source_array.as_ref().and_then(|arr| {
arr.as_any()
.downcast_ref::<StructArray>()
.and_then(|s| s.nulls().cloned())
});

let source_data: &dyn ProvidesColumnByName = match source_array {
Some(ref array) => array
.as_any()
.downcast_ref::<StructArray>()
Expand Down Expand Up @@ -204,7 +211,7 @@ fn evaluate_transform_expression(
return Err(Error::generic("Too many fields in output schema"));
}

// Build the final struct
// Build the final struct, preserving null bitmap for nested transforms
let output_fields: Vec<ArrowField> = output_cols
.iter()
.zip(output_schema.fields())
Expand All @@ -216,7 +223,7 @@ fn evaluate_transform_expression(
)
})
.collect();
let data = StructArray::try_new(output_fields.into(), output_cols, None)?;
let data = StructArray::try_new(output_fields.into(), output_cols, source_null_buffer)?;
Ok(Arc::new(data))
}

Expand Down
Loading