Skip to content

Conversation

@sanujbasu
Copy link
Collaborator

@sanujbasu sanujbasu commented Jan 21, 2026

🥞 Stacked PR

Use this link to review incremental changes.


Add the ability to set table properties when creating a Delta table.

Changes:

  • Add with_table_properties() method that accepts any iterable of (K, V) pairs
  • Supports only custom properties. Delta properties and signal flags to
    support features are deny listed. They will be selectively enabled
    for supported functionality.
  • Method can be called multiple times (properties merge, duplicates overwrite)

Example:

  create_table(path, schema, engine_info)
      .with_table_properties([
          ("myapp.version", "1.0"),
      ])
      .build(engine, committer)?
      .commit(engine)?;

What changes are proposed in this pull request?

Adds the chainable builder method with_table_properties(..) to the create table builder

How was this change tested?

Unit tests added to validate create table building with supported
and unsupported properties.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.64%. Comparing base (158657e) to head (05ae98e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/transaction/create_table.rs 98.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
+ Coverage   84.61%   84.64%   +0.02%     
==========================================
  Files         125      125              
  Lines       34648    34721      +73     
  Branches    34648    34721      +73     
==========================================
+ Hits        29316    29388      +72     
  Misses       3983     3983              
- Partials     1349     1350       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sanujbasu sanujbasu marked this pull request as ready for review January 21, 2026 11:16
Copy link
Collaborator

@scottsand-db scottsand-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent small stacked PR! LGTM -- the changes in this 2nd PR in the stack.

Left some minor comments/questions that I ask you to resolve before merging.

@sanujbasu sanujbasu force-pushed the stack/create_table_2 branch from e64a5b9 to 2073c9b Compare January 23, 2026 23:55
Add the ability to set table properties when creating a Delta table.

Changes:
- Add with_table_properties() method that accepts any iterable of (K, V) pairs
- Supports only custom properties. Delta properties and signal flags to
  support features are deny listed. They will be selectively enabled
  for supported functionality.
- Method can be called multiple times (properties merge, duplicates overwrite)

Example:
  create_table(path, schema, engine_info)
      .with_table_properties([
          ("myapp.version", "1.0"),
      ])
      .build(engine, committer)?
      .commit(engine)?;

Tests
Unit tests added to validate create table building with supported
and unsupported properties.
@sanujbasu sanujbasu force-pushed the stack/create_table_2 branch from 2073c9b to 05ae98e Compare January 24, 2026 00:13
@sanujbasu sanujbasu merged commit a58cbb1 into delta-io:main Jan 24, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants