-
Notifications
You must be signed in to change notification settings - Fork 139
feat: Add with_table_properties method to CreateTableTransactionBuilder #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1649 +/- ##
==========================================
+ Coverage 84.61% 84.64% +0.02%
==========================================
Files 125 125
Lines 34648 34721 +73
Branches 34648 34721 +73
==========================================
+ Hits 29316 29388 +72
Misses 3983 3983
- Partials 1349 1350 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scottsand-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent small stacked PR! LGTM -- the changes in this 2nd PR in the stack.
Left some minor comments/questions that I ask you to resolve before merging.
ccdac7f to
e891a95
Compare
e891a95 to
e64a5b9
Compare
e64a5b9 to
2073c9b
Compare
Add the ability to set table properties when creating a Delta table.
Changes:
- Add with_table_properties() method that accepts any iterable of (K, V) pairs
- Supports only custom properties. Delta properties and signal flags to
support features are deny listed. They will be selectively enabled
for supported functionality.
- Method can be called multiple times (properties merge, duplicates overwrite)
Example:
create_table(path, schema, engine_info)
.with_table_properties([
("myapp.version", "1.0"),
])
.build(engine, committer)?
.commit(engine)?;
Tests
Unit tests added to validate create table building with supported
and unsupported properties.
2073c9b to
05ae98e
Compare
🥞 Stacked PR
Use this link to review incremental changes.
Add the ability to set table properties when creating a Delta table.
Changes:
support features are deny listed. They will be selectively enabled
for supported functionality.
Example:
What changes are proposed in this pull request?
Adds the chainable builder method with_table_properties(..) to the create table builder
How was this change tested?
Unit tests added to validate create table building with supported
and unsupported properties.