Skip to content

[DRAFT] feat: snapshot FFI rework #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
samansmink wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[DRAFT] feat: snapshot FFI rework #1650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78c5fdd
Add builder_from to ffi
samansmink Jan 20, 2026
d0e70e2
attempt to clean up api
samansmink Jan 20, 2026
409f562
write test and minor fix
samansmink Jan 21, 2026
b2b4eff
refactor to single snapshot method
samansmink Jan 21, 2026
16f9ee8
make path optional
samansmink Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ffi/src/domain_metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@
use super::*;
use crate::error::KernelError;
use crate::ffi_test_utils::{
allocate_err, allocate_str, assert_extern_result_error_with_message, ok_or_panic,

Check warning on line 92 in ffi/src/domain_metadata.rs

View workflow job for this annotation

GitHub Actions / format 

Diff in /home/runner/work/delta-kernel-rs/delta-kernel-rs/ffi/src/domain_metadata.rs
recover_string,
};
use crate::{engine_to_handle, free_engine, free_snapshot, kernel_string_slice, snapshot};
use crate::{engine_to_handle, free_engine, free_snapshot, kernel_string_slice, snapshot, OptionalValue};
use delta_kernel::engine::default::DefaultEngineBuilder;
use delta_kernel::DeltaResult;
use object_store::memory::InMemory;
Expand Down Expand Up @@ -184,8 +184,14 @@

add_commit(storage.as_ref(), 1, commit).await.unwrap();

let snapshot =
unsafe { ok_or_panic(snapshot(kernel_string_slice!(path), engine.shallow_copy())) };
let snapshot = unsafe {
ok_or_panic(snapshot(
OptionalValue::Some(kernel_string_slice!(path)),
engine.shallow_copy(),
OptionalValue::None,
OptionalValue::None,
))
};

let get_domain_metadata_helper = |domain: &str| unsafe {
get_domain_metadata(
Expand Down
Loading
Loading