-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass on IN/Not In #270
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
64f7a52
First pass on IN/Not In
hntd187 75a6a3a
In/Not In support for String Arrays and more tests
hntd187 7cb6c45
chore: fmt
hntd187 5be298c
Update kernel/src/engine/arrow_expression.rs
hntd187 0ddcbdf
Merge branch 'main' into in-not-in
hntd187 4a715b2
Address PR feedback
hntd187 bbcbc46
Address PR feedback
hntd187 ae17592
Address PR feedback
hntd187 9de1edc
Merge branch 'main' into in-not-in
hntd187 d7ca9d8
Address PR feedback
hntd187 a03b4fe
Address PR feedback, use dangling pointer for init/empty array instea…
hntd187 36d7b9a
Merge branch 'main' into in-not-in
hntd187 9abd4bc
Merge branch 'main' into in-not-in
hntd187 ff28e09
Merge remote-tracking branch 'mine/in-not-in' into in-not-in
hntd187 0309334
Address PR feedback, as well as resolve some lints and nightly build …
hntd187 ad9ca08
Fix failing test in ffi
hntd187 e2eda49
Updated a test to remove arrow deps
hntd187 52bfc0b
Merge branch 'main' into in-not-in
hntd187 5c968d9
Merge remote-tracking branch 'origin/main' into in-not-in
hntd187 e1fd8f6
Merge branch 'main' into in-not-in
hntd187 b12f8d6
Merge remote-tracking branch 'mine/in-not-in' into in-not-in
hntd187 1c079d9
Added a guard and a test for when the right side column comparison fo…
hntd187 0866f35
Added a test for literal array comparisons
hntd187 112fdf7
chore: fmt
hntd187 ec07f07
added a test for invalid cases and tighten a match arm to not match o…
hntd187 e752ae3
added a test for invalid cases and tighten a match arm to not match o…
hntd187 677581a
Merge remote-tracking branch 'mine/in-not-in' into in-not-in
hntd187 444b1dc
chore:fmt
hntd187 a69a95b
Merge branch 'main' into in-not-in
hntd187 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will
panic!
if$right_arr
isn't a list (like the user passed3 in 3
or something like that). We should return an error instead thatIN
needs anArrayData
type on the right.