Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass on IN/Not In #270

Merged
merged 29 commits into from
Aug 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
64f7a52
First pass on IN/Not In
hntd187 Jun 29, 2024
75a6a3a
In/Not In support for String Arrays and more tests
hntd187 Jun 29, 2024
7cb6c45
chore: fmt
hntd187 Jun 29, 2024
5be298c
Update kernel/src/engine/arrow_expression.rs
hntd187 Jul 1, 2024
0ddcbdf
Merge branch 'main' into in-not-in
hntd187 Jul 1, 2024
4a715b2
Address PR feedback
hntd187 Jul 1, 2024
bbcbc46
Address PR feedback
hntd187 Jul 1, 2024
ae17592
Address PR feedback
hntd187 Jul 5, 2024
9de1edc
Merge branch 'main' into in-not-in
hntd187 Jul 20, 2024
d7ca9d8
Address PR feedback
hntd187 Jul 20, 2024
a03b4fe
Address PR feedback, use dangling pointer for init/empty array instea…
hntd187 Jul 25, 2024
36d7b9a
Merge branch 'main' into in-not-in
hntd187 Aug 2, 2024
9abd4bc
Merge branch 'main' into in-not-in
hntd187 Aug 3, 2024
ff28e09
Merge remote-tracking branch 'mine/in-not-in' into in-not-in
hntd187 Aug 4, 2024
0309334
Address PR feedback, as well as resolve some lints and nightly build …
hntd187 Aug 4, 2024
ad9ca08
Fix failing test in ffi
hntd187 Aug 4, 2024
e2eda49
Updated a test to remove arrow deps
hntd187 Aug 5, 2024
52bfc0b
Merge branch 'main' into in-not-in
hntd187 Aug 5, 2024
5c968d9
Merge remote-tracking branch 'origin/main' into in-not-in
hntd187 Aug 12, 2024
e1fd8f6
Merge branch 'main' into in-not-in
hntd187 Aug 12, 2024
b12f8d6
Merge remote-tracking branch 'mine/in-not-in' into in-not-in
hntd187 Aug 12, 2024
1c079d9
Added a guard and a test for when the right side column comparison fo…
hntd187 Aug 12, 2024
0866f35
Added a test for literal array comparisons
hntd187 Aug 12, 2024
112fdf7
chore: fmt
hntd187 Aug 12, 2024
ec07f07
added a test for invalid cases and tighten a match arm to not match o…
hntd187 Aug 12, 2024
e752ae3
added a test for invalid cases and tighten a match arm to not match o…
hntd187 Aug 12, 2024
677581a
Merge remote-tracking branch 'mine/in-not-in' into in-not-in
hntd187 Aug 12, 2024
444b1dc
chore:fmt
hntd187 Aug 12, 2024
a69a95b
Merge branch 'main' into in-not-in
hntd187 Aug 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kernel/src/engine/arrow_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ macro_rules! prim_array_cmp {
$right_arr.as_list::<i32>(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will panic! if $right_arr isn't a list (like the user passed 3 in 3 or something like that). We should return an error instead that IN needs an ArrayData type on the right.

).map(wrap_comparison_result),
)+
_ => unimplemented!()
_ => Err(ArrowError::CastError(format!("Bad Comparison between: {:?} and {:?}", $left_arr.data_type(), $right_arr.data_type())))
scovich marked this conversation as resolved.
Show resolved Hide resolved
}.map_err(Error::generic_err);
};
}
Expand Down
Loading