prepare 0.3.0 #305
Merged
prepare 0.3.0 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=======================================
Coverage 72.51% 72.51%
=======================================
Files 43 43
Lines 7783 7783
Branches 7783 7783
=======================================
Hits 5644 5644
Misses 1768 1768
Partials 371 371 ☔ View full report in Codecov by Sentry. |
zachschuermann
force-pushed
the
cut-0.2.1
branch
from
47fc9ec to
ccdaf08
Compare
nicklan
approved these changes
Aug 7, 2024
| @@ -167,6 +167,8 @@ impl DeletionVectorDescriptor { | |||
| } | |||
| } | |||
|
|
|||
| /// Materialize the row indexes of the deletion vector as a Vec<u64> in which each element | |||
There was a problem hiding this comment.
Generally I don't love making any "real" changes in these kinds of PRs. For now it's probably fine, but we should get in the habit of making these first
There was a problem hiding this comment.
Ah yea agree probably not the best spot for it - just noticed we missed some documentation earlier..
There was a problem hiding this comment.
Agreed with Nick, but I appreciate you plugging the hole here
rtyler
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release
0.3.0🚀(don't merge for me please, I'll adjust the date in the changelog when I'm actually about to do the release)