Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude golden tests+data when publishing package #307

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

zachschuermann
Copy link
Collaborator

@zachschuermann zachschuermann commented Aug 7, 2024

We exceeded 10MB limit on crates.io for package size. Exclude golden tests and golden data from publishing to stay under the limit.

new package size:

 Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.96s
    Packaged 112 files, 557.5KiB (120.8KiB compressed)

old package size (and error):

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.06s
    Packaged 203 files, 13.9MiB (13.0MiB compressed)
   Uploading delta_kernel v0.3.0 (/Users/zach.schuermann/dev/delta-kernel-rs/kernel)
error: failed to publish to registry at https://crates.io

Caused by:
  the remote server responded with an error (status 413 Payload Too Large): max upload size is: 10485760

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (f8b0485) to head (2d86f5a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   72.51%   72.51%           
=======================================
  Files          43       43           
  Lines        7783     7783           
  Branches     7783     7783           
=======================================
  Hits         5644     5644           
  Misses       1768     1768           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachschuermann zachschuermann merged commit 886ac9c into delta-io:main Aug 7, 2024
12 checks passed
@zachschuermann zachschuermann deleted the exclude-golden-tests branch August 7, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants