Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contributing file #329

Merged
merged 2 commits into from
Sep 21, 2024
Merged

add contributing file #329

merged 2 commits into from
Sep 21, 2024

Conversation

MrPowers
Copy link
Contributor

@MrPowers MrPowers commented Sep 7, 2024

Fixes #321

The CONTRIBUTING.md file is conventional in OSS repos. This one draws inspiration from the Rails CONTRIBUTING.md file.

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1459b30). Learn more about missing BASE report.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage        ?   74.03%           
=======================================
  Files           ?       43           
  Lines           ?     8137           
  Branches        ?     8137           
=======================================
  Hits            ?     6024           
  Misses          ?     1733           
  Partials        ?      380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CONTRIBUTING.md Outdated

## Do you have questions about the source code?

Feel free to create an issue or join the Delta Lake Slack channel with questions!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link slack channel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We unfortunately can't provide a link cause Slack channel links die every 30 days 🙃

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or rather the slack workspace in general? can we have the overall slack workspace link?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delta-users.slack.com right?

Suggested change
Feel free to create an issue or join the Delta Lake Slack channel with questions!
Feel free to create an issue or join the Delta Lake Slack channel (`#delta-kernel` on delta-users.slack.com) with questions!

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great. lgtm, feel free to accept my slack channel suggestion if it makes sense, or something else if not. Probably good if we can give some way they can track down where the slack channel is.

CONTRIBUTING.md Outdated

## Do you have questions about the source code?

Feel free to create an issue or join the Delta Lake Slack channel with questions!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delta-users.slack.com right?

Suggested change
Feel free to create an issue or join the Delta Lake Slack channel with questions!
Feel free to create an issue or join the Delta Lake Slack channel (`#delta-kernel` on delta-users.slack.com) with questions!

@MrPowers
Copy link
Contributor Author

@nicklan @zachschuermann - thanks for reviewing!

I added this Slack link: https://go.delta.io/slack

I checked and that's what's used on the delta.io site.

Let me know if you have any additional comments!

@nicklan nicklan merged commit 4c9a6ac into delta-io:main Sep 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CONTRIBUTING.md file
4 participants