Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare 0.3.1 #330

Merged
merged 4 commits into from
Sep 10, 2024
Merged

prepare 0.3.1 #330

merged 4 commits into from
Sep 10, 2024

Conversation

zachschuermann
Copy link
Collaborator

release 0.3.1 🚀

diff from 0.3.0..main
(don't merge for me please, I'll adjust the date in the changelog when I'm actually about to do the release)

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (2291a87) to head (938fcd9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   73.86%   73.86%           
=======================================
  Files          43       43           
  Lines        8078     8078           
  Branches     8078     8078           
=======================================
  Hits         5967     5967           
  Misses       1732     1732           
  Partials      379      379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

CHANGELOG.md Outdated
Comment on lines 11 to 14
1. Two new binary expressions: `In` and `NotIn`, as well as a new `Scalar::Array` variant to represent arrays in the expression framework [\#270](https://github.com/delta-incubator/delta-kernel-rs/pull/270)
a. `Scalar::Array` wraps new `ArrayData` type
b. New `DataType::Array` constructor: `DataType::array_type(elements: ArrayType) -> Self`
c. New `Error` variant: `InvalidExpressionEvaluation` and corresponding `invalid_expression(...)` function
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be brag about these when we don't actually like that they're part of the public API, and hoping they will disappear Real Soon Now? Perhaps we should at least add the warning that they're unstable and likely to change or be removed soon?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I would prefer to err on the side of transparency (and include them) but we can have a warning along with it? Do you mean to warn that all of the In/NotIn is unstable and likely to change/be removed? cc @nicklan

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed a, b, c and added a note that these APIs are evolving

@zachschuermann zachschuermann merged commit 04e6a18 into delta-io:main Sep 10, 2024
12 checks passed
@zachschuermann zachschuermann deleted the prepare-0.3.1 branch September 10, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants