Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add arrow-buffer to arrow-expression feature #332

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

zachschuermann
Copy link
Collaborator

When running cargo-publish the delta_kernel crate failed to compile; needed to add arrow-buffer to arrow-expression feature.

error[E0432]: unresolved import `arrow_buffer`
  --> src/engine/arrow_expression.rs:13:5
   |
13 | use arrow_buffer::OffsetBuffer;
   |     ^^^^^^^^^^^^ use of undeclared crate or module `arrow_buffer`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `delta_kernel` (lib) due to 1 previous error

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (04e6a18) to head (9958088).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   73.86%   73.86%           
=======================================
  Files          43       43           
  Lines        8078     8078           
  Branches     8078     8078           
=======================================
  Hits         5967     5967           
  Misses       1732     1732           
  Partials      379      379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachschuermann
Copy link
Collaborator Author

I suppose to catch something like this we could run cargo package in the CI but that feels clunky..? Anyone know if we can mimic cargo-publish just through the right cargo build incantation?

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! can you make a follow-up to make some compile tests with reasonable feature flags enabled/disabled

@zachschuermann
Copy link
Collaborator Author

Created #333 for follow-up!

@zachschuermann zachschuermann merged commit 2547322 into delta-io:main Sep 10, 2024
12 checks passed
@zachschuermann zachschuermann deleted the fix-arrow-buffer-0.3.1 branch September 10, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants