Remove feature flag requirement for GetData on () #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the GetData trait implementation for unit type () is in arrow_get_data.rs. This makes the trait impl blocked behind either the default-engine or sync-engine flags. This PR moves the GetData trait implementation to engine_data.rs to make it available without the flags.
OussamaSaoudi-db
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 73.86% 73.86%
=======================================
Files 43 43
Lines 8078 8078
Branches 8078 8078
=======================================
Hits 5967 5967
Misses 1732 1732
Partials 379 379 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the GetData trait implementation for unit type
()is in arrow_get_data.rs. This makes the trait impl blocked behind either thedefault-engineorsync-engineflags. This PR moves the GetData trait implementation to engine_data.rs to make it available without the flags so that it can be used by other engines.Closes: #315