-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map access for expressions #352
Open
hntd187
wants to merge
16
commits into
delta-io:main
Choose a base branch
from
hntd187:map_access
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
27b414b
feat: ability to write expressions that access map values and express…
hntd187 d2907d9
feat: ability to write expressions that access map values and express…
hntd187 fe57b9b
Merge branch 'main' into map_access
hntd187 4921f19
revert HashMap<_, Option<_>> changes for partition values
hntd187 6091137
Merge branch 'main' into map_access
hntd187 c33e98c
Update kernel/src/engine/arrow_expression.rs
hntd187 5de6693
tests use BTreeMap instead of HashMap now
hntd187 037f922
Remove an import
hntd187 fcad16f
More tests, NotNull unary operation
hntd187 c6f449c
Merge branch 'main' of https://github.com/delta-incubator/delta-kerne…
hntd187 42c1422
feat: map expressions
hntd187 269d5a5
Merge branch 'main' of https://github.com/delta-incubator/delta-kerne…
hntd187 9ae06a5
Merge branch 'main' of https://github.com/delta-incubator/delta-kerne…
hntd187 0f43e71
feat: map expressions
hntd187 e519994
feat: map expressions
hntd187 ba16e68
Merge branch 'main' into map_access
hntd187 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right? The nullability of a list (or map) should be independent of whether the list elements (mapped values) are nullable? ie
Option<Vec<T>>
andVec<Option<T>>
(orOption<HashMap>
andHashMap<K, Option<V>>
) should be orthogonal?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up removing this based on Nick's feedback