Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement row group skipping for the default engine parquet readers #362

Merged
merged 33 commits into from
Oct 9, 2024

review nits

4a77f3a
Select commit
Loading
Failed to load commit list.
Merged

Implement row group skipping for the default engine parquet readers #362

review nits
4a77f3a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 0s

77.66% (+0.59%) compared to 1c4b9ce

View this Pull Request on Codecov

77.66% (+0.59%) compared to 1c4b9ce

Details

Codecov Report

Attention: Patch coverage is 85.61525% with 83 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (1c4b9ce) to head (4a77f3a).

Files with missing lines Patch % Lines
kernel/src/engine/parquet_row_group_skipping.rs 52.79% 26 Missing and 50 partials ⚠️
kernel/src/engine/default/parquet.rs 50.00% 5 Missing ⚠️
kernel/src/snapshot.rs 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   77.06%   77.66%   +0.59%     
==========================================
  Files          47       49       +2     
  Lines        9524    10079     +555     
  Branches     9524    10079     +555     
==========================================
+ Hits         7340     7828     +488     
- Misses       1790     1805      +15     
- Partials      394      446      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.