Fixing semver check #383
Merged
Fixing semver check #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage 77.06% 77.06%
=======================================
Files 47 47
Lines 9524 9524
Branches 9524 9524
=======================================
Hits 7340 7340
Misses 1790 1790
Partials 394 394 ☔ View full report in Codecov by Sentry. |
nicklan
force-pushed
the
test-semver-check
branch
from
18143f4 to
198eeef
Compare
nicklan
force-pushed
the
test-semver-check
branch
from
d43eec3 to
6b2ce4b
Compare
zachschuermann
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually need to use
pull_request_target. This is how delta-rs does it and is also what github support suggests.We do take a risk that if someone exploits
cargo semver-checksthey could execute code against our repo. That doesn't seem like a high risk.The check won't run here as in this case we really do need it to be merged to main.