- 
                Notifications
    
You must be signed in to change notification settings  - Fork 119
 
feat: Add the in-commit timestamp field to CommitInfo #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      a513a09
              
                Add ict and tests
              
              
                OussamaSaoudi-db bc3ff0c
              
                Update docs for ICT
              
              
                OussamaSaoudi-db db5e301
              
                Assert selection vector
              
              
                OussamaSaoudi-db c57c645
              
                wip ict impl
              
              
                OussamaSaoudi-db 64efb75
              
                add tmp ict fixup for writes
              
              
                OussamaSaoudi-db e2f44b9
              
                remove non_ict schema
              
              
                OussamaSaoudi-db acac33c
              
                fix commit
              
              
                OussamaSaoudi-db f52b5fc
              
                Remove cdf changes for ict
              
              
                OussamaSaoudi-db ae2b7d1
              
                remove unused imports
              
              
                OussamaSaoudi-db f8909ba
              
                Add clarifying comment for inCommitTimestamp
              
              
                OussamaSaoudi-db fb1ff2f
              
                Add documentation for ICT
              
              
                OussamaSaoudi-db 7258611
              
                Merge branch 'main' into cdf_ict
              
              
                OussamaSaoudi-db d37a191
              
                Merge branch 'main' into cdf_ict
              
              
                OussamaSaoudi File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zachschuermann just flagging this comment and approach to writing ICT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine :) can we add an issue link/todo so we are tracking this?