-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Port cdf tests from delta-spark to kernel #611
Merged
OussamaSaoudi
merged 12 commits into
delta-io:main
from
OussamaSaoudi-db:cdf_delta_spark_tests
Jan 15, 2025
+324
−13
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bd11f8e
Add simple tests
OussamaSaoudi-db 38f7b26
Add delta-spark cdf tests
OussamaSaoudi-db e8cc395
Add deletion tests
OussamaSaoudi-db 67a8596
address issues
OussamaSaoudi-db 249f457
Remove unnecessary file
OussamaSaoudi-db 6caa32e
rename to consistent naming
OussamaSaoudi-db 8be1910
Merge branch 'main' into cdf_delta_spark_tests
OussamaSaoudi-db 47ea246
Remove unnecessary Ok(())
OussamaSaoudi-db 18e97a0
remove xattrs
OussamaSaoudi-db c8a01ac
Merge branch 'main' into cdf_delta_spark_tests
OussamaSaoudi-db 820a384
Merge branch 'main' into cdf_delta_spark_tests
OussamaSaoudi 8156f9b
Merge branch 'main' into cdf_delta_spark_tests
OussamaSaoudi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
address issues
commit 67a859622eebcf2a497e508801caf43226990dcf
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we observing
update_pre
andupdate_post
here then? aren't we reading the CDF and then filling in our ownupdate_preimage
etc.?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All update
_change_type
s come directly from a cdc file. We don't insert or modify them. In this test, delta-spark wrote update_pre and update_post directly into the cdc file.