Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Clarify JsonHandler semantics on EngineData ordering #635

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

OussamaSaoudi
Copy link
Collaborator

@OussamaSaoudi OussamaSaoudi commented Jan 10, 2025

What changes are proposed in this pull request?

When reading multiple log files during log replay, it is important that we read commits in order. This ensures the correctness of add/remove deduplication. Hence, we are implicitly relying on the commit files being read in order by the json handler.

Moreover when in-commit timestamps is enabled, the ordering of batches of engine data in a commit is important. A correct delta table should have the commit info be the first action in a log file.

This PR makes the expected semantics of the JsonHandler clearer with some added documentation.

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Jan 10, 2025
@OussamaSaoudi-db OussamaSaoudi-db removed the breaking-change Change that will require a version bump label Jan 13, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (b3546f0) to head (961f039).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   83.45%   83.43%   -0.03%     
==========================================
  Files          75       75              
  Lines       16918    16918              
  Branches    16918    16918              
==========================================
- Hits        14119    14115       -4     
- Misses       2145     2147       +2     
- Partials      654      656       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@OussamaSaoudi OussamaSaoudi merged commit 9c43bf4 into delta-io:main Jan 14, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants