doc: Clarify JsonHandler
semantics on EngineData ordering
#635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
When reading multiple log files during log replay, it is important that we read commits in order. This ensures the correctness of add/remove deduplication. Hence, we are implicitly relying on the commit files being read in order by the json handler.
Moreover when in-commit timestamps is enabled, the ordering of batches of engine data in a commit is important. A correct delta table should have the commit info be the first action in a log file.
This PR makes the expected semantics of the
JsonHandler
clearer with some added documentation.