fix: remove 'default-members' in workspace, default to all crates #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 84.36% 84.36%
=======================================
Files 81 81
Lines 19246 19246
Branches 19246 19246
=======================================
Hits 16236 16236
Misses 2205 2205
Partials 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
the
breaking-change
roeap
approved these changes
Mar 21, 2025
zachschuermann
removed
the
breaking-change
nicklan
reviewed
Mar 21, 2025
| @@ -54,6 +54,8 @@ impl Drop for FileReadResultIterator { | |||
| /// | |||
| /// The iterator must be valid (returned by [`read_parquet_file`]) and not yet freed by | |||
| /// [`free_read_result_iter`]. The visitor function pointer must be non-null. | |||
| /// | |||
| /// [`free_engine_data`]: crate::free_engine_data | |||
There was a problem hiding this comment.
ohh nm, i guess it creates the link in the docs?
nicklan
approved these changes
Mar 21, 2025
sebastiantia
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: new contributors have compilation errors which aren't raised when they run a normal
cargo testorcargo nextest runsince FFI crate (among others) aren't built by default.Solution: remove
default-members = ["acceptance", "kernel"]in our workspace'sCargo.tomlin order to default to building all crates.This PR includes the update above + some fixes for docs, clippy, etc. and modifies how we run
clippy --no-default-featuresin CI so that we actually check kernel without any features enabled.