Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return Error::unsupported instead of panic in Scalar::to_array(MapType) #757

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

zachschuermann
Copy link
Collaborator

title. fixing a panic: return error instead.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (74aab72) to head (1907e3f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/engine/arrow_expression/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   84.38%   84.37%   -0.01%     
==========================================
  Files          80       80              
  Lines       19219    19221       +2     
  Branches    19219    19221       +2     
==========================================
  Hits        16218    16218              
- Misses       2199     2201       +2     
  Partials      802      802              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I wonder how many other random panics are lurking...

@zachschuermann zachschuermann merged commit 3065a76 into delta-io:main Mar 20, 2025
19 of 21 checks passed
@zachschuermann zachschuermann deleted the map-unimplemented branch March 20, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants