deprecate: IN/NOT IN #758
Open
deprecate: IN/NOT IN #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scovich
reviewed
Mar 20, 2025
| @@ -41,8 +41,18 @@ pub enum BinaryOperator { | |||
| /// Distinct | |||
| Distinct, | |||
| /// IN | |||
| #[deprecated( | |||
| note = "IN expressions are deprecated and will be removed soon. Opaque expressions will \ | |||
| allow for engines to interpret expressions which are not included in the kernel's \ | |||
There was a problem hiding this comment.
"... [implement and] interpret..."?
|
blocking on opaque expr support: #686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
deprecate
INandNOT INexpressions. since they aren't used in delta protocol we shouldn't build directly into kernel and instead leverage opaque expressions to allow for engines to support any expressions they want without placing requirements on the kernel's expression language.This PR affects the following public APIs
deprecates
INandNOT INexpressionsHow was this change tested?
existing