refactor!: update ScanMetadata to struct with new FilteredEngineData type
#768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 84.87% 84.88%
=======================================
Files 83 83
Lines 20316 20311 -5
Branches 20316 20311 -5
=======================================
- Hits 17244 17241 -3
- Misses 2221 2222 +1
+ Partials 851 848 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sebastiantia
changed the title
ScanData struct with new FilteredEngineData typeScanData to struct with new FilteredEngineData type
nicklan
reviewed
Mar 26, 2025
kernel/src/scan/mod.rs
Outdated
| .map(|res| { | ||
| let (data, vec, transforms) = res?; | ||
| let scan_data = res?; | ||
| let (data, sel_vec) = scan_data.filtered_data; | ||
| let scan_files = vec![]; | ||
| state::visit_scan_files( |
There was a problem hiding this comment.
Should we have a visit_scan_data_files or similar that just takes the ScanData? Then we don't have to do this decomposition all over the place
There was a problem hiding this comment.
How about updating visit_scan_files to just take ScanData?
There was a problem hiding this comment.
discussed a little offline: i'm kinda partial to a ScanData.visit(callback, context)?
There was a problem hiding this comment.
Implemented @zachschuermann 's approach
kernel/src/scan/mod.rs
Outdated
| .map(|res| { | ||
| let (data, vec, transforms) = res?; | ||
| let scan_data = res?; | ||
| let (data, sel_vec) = scan_data.filtered_data; | ||
| let scan_files = vec![]; | ||
| state::visit_scan_files( |
There was a problem hiding this comment.
discussed a little offline: i'm kinda partial to a ScanData.visit(callback, context)?
scovich
approved these changes
Apr 9, 2025
Merged
nicklan
approved these changes
Apr 9, 2025
zachschuermann
approved these changes
Apr 9, 2025
zachschuermann
added a commit
that referenced
this pull request
Apr 9, 2025
## What changes are proposed in this pull request? Rename `ScanData` to `ScanMetadata` and `Scan::scan_data` to `Scan::scan_metadata` (and corresponding FFI). Additionally, renames `TableChangesScanData` to `TableChangesScanMetadata`. Additional docs/refactor coming in #768 ### This PR affects the following public APIs breaking changes: 1. rename `ScanData` to `ScanMetadata` 2. rename `Scan::scan_data()` to `Scan::scan_metadata()` 3. (ffi) rename `free_kernel_scan_data()` to `free_scan_metadata_iter()` 4. (ffi) rename `kernel_scan_data_next()` to `scan_metadata_next()` 5. (ffi) rename `visit_scan_data()` to `visit_scan_metadata()` 6. (ffi) rename `kernel_scan_data_init()` to `scan_metadata_iter_init()` 7. (ffi) rename `KernelScanDataIterator` to `ScanMetadataIterator` 8. (ffi) rename `SharedScanDataIterator` to `SharedScanMetadataIterator` ## How was this change tested? existing resolves #816
sebastiantia
changed the title
ScanData to struct with new FilteredEngineData typeScanMetadata to struct with new FilteredEngineData type
sebastiantia
deleted the
seb/scan-data-refactor-with-filtered-engine-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
ScanMetatafrom typed tuple to struct. ScanMetadata is now a struct with fields:FilteredEngineDatainstance.Introduction of
FilteredEngineDatatype:Couples
EngineDatawith a selection vector indicating which rows to process.This type is returned from the
scan_metadataAPI and the incomingcheckpointAPIUpdates
visit_scan_filesparameters to acceptScanMetadatato avoid de-structuring.Corresponding FFI changes for
visit_scan_filesto acceptScanMetadataparamAll current tests pass.