refactor!: update ScanData to struct with new FilteredEngineData type
#768
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 84.35% 84.38% +0.03%
==========================================
Files 81 81
Lines 19233 19249 +16
Branches 19233 19249 +16
==========================================
+ Hits 16224 16244 +20
+ Misses 2205 2201 -4
Partials 804 804 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sebastiantia
changed the title
ScanData struct with new FilteredEngineData typeScanData to struct with new FilteredEngineData type
kernel/src/scan/mod.rs
Outdated
| .map(|res| { | ||
| let (data, vec, transforms) = res?; | ||
| let scan_data = res?; | ||
| let (data, sel_vec) = scan_data.filtered_data; | ||
| let scan_files = vec![]; | ||
| state::visit_scan_files( |
There was a problem hiding this comment.
Should we have a visit_scan_data_files or similar that just takes the ScanData? Then we don't have to do this decomposition all over the place
There was a problem hiding this comment.
How about updating visit_scan_files to just take ScanData?
There was a problem hiding this comment.
discussed a little offline: i'm kinda partial to a ScanData.visit(callback, context)?
There was a problem hiding this comment.
Implemented @zachschuermann 's approach
kernel/src/engine_data.rs
Outdated
| /// | ||
| /// `Box<dyn EngineData>` - The underlying data | ||
| /// `Vec<bool>` - Selection vector where `true` marks rows to include in results | ||
| pub type FilteredEngineData = (Box<dyn EngineData>, Vec<bool>); |
There was a problem hiding this comment.
what about just making this a struct?
kernel/src/scan/mod.rs
Outdated
| .map(|res| { | ||
| let (data, vec, transforms) = res?; | ||
| let scan_data = res?; | ||
| let (data, sel_vec) = scan_data.filtered_data; | ||
| let scan_files = vec![]; | ||
| state::visit_scan_files( |
There was a problem hiding this comment.
discussed a little offline: i'm kinda partial to a ScanData.visit(callback, context)?
What changes are proposed in this pull request?
ScanDatafrom typed tuple to struct. ScanData is now a struct with fields:FilteredEngineDatainstance.Introduction of
FilteredEngineDatatype:Couples
EngineDatawith a selection vector indicating which rows to process.This type is returned from the
scan_dataAPI and the incomingcheckpointAPIUpdates
visit_scan_filesparameters to acceptScanDatato avoid de-structuring.Corresponding FFI changes for
visit_scan_filesto acceptScanDataparamHow was this change tested?
All current tests pass.