Skip to content

feat!: Split out predicates as different from expressions #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 7, 2025

fix logical merge conflict

886b87e
Select commit
Loading
Failed to load commit list.
Merged

feat!: Split out predicates as different from expressions #775

fix logical merge conflict
886b87e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 7, 2025 in 1s

84.68% (-0.60%) compared to a93a85a

View this Pull Request on Codecov

84.68% (-0.60%) compared to a93a85a

Details

Codecov Report

Attention: Patch coverage is 70.84399% with 342 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (a93a85a) to head (886b87e).

Files with missing lines Patch % Lines
ffi/src/expressions/engine.rs 0.00% 87 Missing ⚠️
ffi/src/expressions/kernel.rs 0.00% 72 Missing ⚠️
ffi/src/test_ffi.rs 0.00% 52 Missing ⚠️
kernel/src/kernel_predicates/tests.rs 65.62% 4 Missing and 29 partials ⚠️
kernel/src/expressions/mod.rs 86.25% 22 Missing ⚠️
kernel/src/expressions/transforms.rs 88.41% 13 Missing and 6 partials ⚠️
...src/engine/arrow_expression/evaluate_expression.rs 68.42% 11 Missing and 7 partials ⚠️
kernel/src/kernel_predicates/mod.rs 90.90% 14 Missing ⚠️
kernel/src/scan/data_skipping/tests.rs 90.14% 5 Missing and 2 partials ⚠️
kernel/src/engine/arrow_expression/mod.rs 81.48% 0 Missing and 5 partials ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   85.28%   84.68%   -0.60%     
==========================================
  Files          88       88              
  Lines       22260    22610     +350     
  Branches    22260    22610     +350     
==========================================
+ Hits        18985    19148     +163     
- Misses       2305     2484     +179     
- Partials      970      978       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov