Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: downgrade stale _last_checkpoint log from warn! to info! #777

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sebastiantia
Copy link
Collaborator

What changes are proposed in this pull request?

Downgrade warn! to info! when _last_checkpoint is stale. Since _last_checkpoint is only a hint and may frequently be out of date in a busy system, logging it as a warning is unnecessary. Clients can still see the info-level log if needed.

@sebastiantia sebastiantia changed the title feat: downgrade stale _last_checkpoint log from warn! to info! refactor: downgrade stale _last_checkpoint log from warn! to info! Mar 28, 2025
@sebastiantia sebastiantia changed the title refactor: downgrade stale _last_checkpoint log from warn! to info! refactor: downgrade stale _last_checkpoint log from warn! to info! Mar 28, 2025
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (9290930) to head (ade2a23).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
- Coverage   84.64%   84.62%   -0.03%     
==========================================
  Files          82       82              
  Lines       19735    19735              
  Branches    19735    19735              
==========================================
- Hits        16705    16701       -4     
- Misses       2214     2216       +2     
- Partials      816      818       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Mar 28, 2025
Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from @scovich: let's do info! by default but warn! if outside log retention duration

@sebastiantia
Copy link
Collaborator Author

@zachschuermann Took a quick look, it will be a bit challenging to leverage the history retention window since the checkpoint hint does not include the creation timestamp, only version.

To leverage the retention window, we would need to pull the last checkpoint's file metadata during log listing which requires more changes than a warning might be worth? Thinking about merging this one for now and tracking the other with an issue. #791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require a version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants