-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: downgrade stale _last_checkpoint
log from warn!
to info!
#777
base: main
Are you sure you want to change the base?
refactor: downgrade stale _last_checkpoint
log from warn!
to info!
#777
Conversation
warn!
to info!
warn!
to info!
warn!
to info!
_last_checkpoint
log from warn!
to info!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
==========================================
- Coverage 84.64% 84.62% -0.03%
==========================================
Files 82 82
Lines 19735 19735
Branches 19735 19735
==========================================
- Hits 16705 16701 -4
- Misses 2214 2216 +2
- Partials 816 818 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from @scovich: let's do info!
by default but warn!
if outside log retention duration
@zachschuermann Took a quick look, it will be a bit challenging to leverage the history retention window since the checkpoint hint does not include the creation timestamp, only version. To leverage the retention window, we would need to pull the last checkpoint's file metadata during log listing which requires more changes than a warning might be worth? Thinking about merging this one for now and tracking the other with an issue. #791 |
What changes are proposed in this pull request?
Downgrade
warn!
toinfo!
when_last_checkpoint
is stale. Since_last_checkpoint
is only a hint and may frequently be out of date in a busy system, logging it as a warning is unnecessary. Clients can still see the info-level log if needed.