refactor: add const (and increase value) for commit files buffer size #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 84.68% 84.66% -0.03%
==========================================
Files 83 83
Lines 19816 19816
Branches 19816 19816
==========================================
- Hits 16782 16778 -4
- Misses 2216 2218 +2
- Partials 818 820 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sebastiantia
approved these changes
Mar 31, 2025
| @@ -24,6 +24,11 @@ use url::Url; | |||
| #[cfg(test)] | |||
| mod tests; | |||
|
|
|||
| // This is the size of the buffer we use hold commit file names during log listing. We expect | |||
There was a problem hiding this comment.
This is the size of the buffer we use to hold commit file names during log listing.
nicklan
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
add a new const:
COMMIT_FILES_LIST_BUFFER_LENGTHand increase value from10to200How was this change tested?
existing