[WIP] refactor: Add enumset to refactor ensure_supported_features #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maruschin
force-pushed
the
refactor_ensure_supported_features_with_enumset
branch
from
c46c4e6 to
9950dd5
Compare
maruschin
changed the title
maruschin
force-pushed
the
refactor_ensure_supported_features_with_enumset
branch
from
9950dd5 to
a5d4178
Compare
maruschin
force-pushed
the
refactor_ensure_supported_features_with_enumset
branch
from
a5d4178 to
67af9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
With enumset the code looks cleaner and further refactoring will only simplify working with protocol versions and features.
Part of: #650
How was this change tested?
I improved and rewrote old tests.