Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update dependencies #814

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zachschuermann
Copy link
Collaborator

@zachschuermann zachschuermann commented Apr 8, 2025

title, minimal changes to integrate some breaking changes. note that this is not a breaking change for kernel since the types from crates with breaking changes never escape the kernel.

breaking updates (remaining updates are all non-breaking):

  • itertools 0.13 -> 0.14
    • itertools 0.14 increases MSRV and removes a generic param from a function we don't use
  • thiserror 1 -> 2
    • thiserror 2 seems to impose restrictions which don't affect us.
  • strum 0.26 -> 0.27
    • two breaking update for their release (1) MSRV increase to 1.66 and (2) something to do with EnumProperties which we don't use.
  • (build dep) ureq 2.10 -> 3
  • (dev dep) datatest-stable 0.2 -> 0.3

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (e74d18b) to head (4d289e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
+ Coverage   85.01%   85.03%   +0.01%     
==========================================
  Files          84       84              
  Lines       20656    20656              
  Branches    20656    20656              
==========================================
+ Hits        17561    17565       +4     
+ Misses       2228     2226       -2     
+ Partials      867      865       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is this a chore! that needs breaking-change label?

@zachschuermann
Copy link
Collaborator Author

LGTM, but is this a chore! that needs breaking-change label?

thanks, sorry should have been more specific here - i've updated PR description with more details, but TLDR no, i don't think so

@zachschuermann
Copy link
Collaborator Author

actually, due to cargo's dependency resolution i suppose upgrading any dependencies' major version is a breaking change..?

@zachschuermann zachschuermann changed the title chore: update dependencies chore!: update dependencies Apr 10, 2025
@zachschuermann zachschuermann added the breaking-change Change that will require a version bump label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require a version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants