Skip to content

Conversation

@gotocoding-DB
Copy link
Contributor

@gotocoding-DB gotocoding-DB commented Apr 10, 2025

What changes are proposed in this pull request?

In #699 table_root was removed from params, just fix the docs after this change.

How was this change tested?

@gotocoding-DB
Copy link
Contributor Author

gotocoding-DB commented Apr 10, 2025

@roeap please check this. I don't have enough access to add you to reviewers in this PR.

Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @gotocoding-DB!

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (929ac08) to head (1927f85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   85.03%   85.01%   -0.02%     
==========================================
  Files          84       84              
  Lines       20656    20656              
  Branches    20656    20656              
==========================================
- Hits        17565    17561       -4     
- Misses       2226     2228       +2     
- Partials      865      867       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@zachschuermann zachschuermann merged commit e74d18b into delta-io:main Apr 10, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants