refactor: Rename predicates mod to kernel_predicates #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 85.01% 85.03% +0.02%
==========================================
Files 84 84
Lines 20656 20657 +1
Branches 20656 20657 +1
==========================================
+ Hits 17561 17566 +5
+ Misses 2228 2226 -2
+ Partials 867 865 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zachschuermann
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
nit: might help to have some module-level documentation to help guide readers on what a kernel_predicate encompasses?
There was a problem hiding this comment.
Tracked as a follow-up: #828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The
predicatesmodule has a confusing name because it sits alongside theexpressionsmodule but does not actually define predicates (= boolean-valued expressions) at all. Instead, it contains kernel's implementation of predicate evaluation, used for e.g. data skipping and partition pruning.Rename the module to
kernel_predicatesand rename corresponding classes likePredicateEvaluatortoKernelPredicateEvaluator, to make their purpose more clear. This also helps clear the way for us to split out predicates as a separate concept from normal expressions, see #765.How was this change tested?
Module and class renames only. Compilation suffices.