feat: new #[derive(IntoEngineData)]
proc macro
#830
+156
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
With the introduction of
EvaluationHandler::create_one
, we can createEngineData
now. This PR adds a handy new procedural macro to implement a newIntoEngineData
trait which allows forself.into_engine_data(&dyn Engine)
as long as the struct implementsToSchema
(usually via#[derive(Schema)]
) and all fields implementInto<Scalar>
Few open questions:
into_engine_data(self, &engine)
? I propose yes, then we can avoid copies in the case the user is actually done with the original struct.ToSchema
and all fields implInto<Scalar>
? where is the best place to enforce that?How was this change tested?
new UT