-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sketch / MVP: Upgrade to arrow-rs 55.0.0 / parquet 55.0.0 / object_store 0.12.0 #831
base: main
Are you sure you want to change the base?
Conversation
@@ -1,17 +1,13 @@ | |||
//! This module exists to help re-export the version of arrow used by default-engine and other | |||
//! parts of kernel that need arrow | |||
|
|||
#[cfg(feature = "arrow_53")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure that simply deleting support for the older arrow releases is not the right approach for this crate but it was the most expedient for my purposes
awesome, thanks @alamb! just saw arrow 55 is out, thanks for starting this - ill pick it up and see if we can support arrow 55 soon! regarding your questions:
yea we have pinned chrono so that we can support arrow 53 (some context here) - perhaps we can just get by with dropping 53 support now and just do 54/55?
ah yep - I can try to follow up over there to see if they can bump too! |
I don't think I am in a position to judge this 🤷 -- that will be on the maintainers of this crate I think |
did the same thing for the |
@alamb Thanks for taking a crack at this, I noticed 55 yesterday when doing Personally I think the hdfs-native-object-store is a boat anchor that should be I'll see what I can do with the chrono juggling to ensure that kernel try to keep support for multiple arrow versions via feature flags. If we can get that to work, then the arrow_55 flag could go into a 0.9.1 without much trouble 🤞 |
Donator of the code here. What trouble does it cause? First I'm hearing of any issues. Just something with transitive dependencies? I didn't notice there was a new object store release, but happy to push a new release out asap for it. |
This is part of testing delta.rs with DataFusion 37 (which will, among other things, use a new version of arrow-rs and object_store)
I don't really intend this PR to be merged as is -- it is simply enough modifications to get the code to compile to unblock me testing delta.rs
Notes for anyone who finds this PR:
Note this is based on the
v0.8.0
tag