-
Notifications
You must be signed in to change notification settings - Fork 139
refactor: combine actions counts in CheckpointVisitor
#883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: combine actions counts in CheckpointVisitor
#883
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
==========================================
- Coverage 85.11% 85.11% -0.01%
==========================================
Files 87 87
Lines 21874 21865 -9
Branches 21874 21865 -9
==========================================
- Hits 18619 18610 -9
Misses 2298 2298
Partials 957 957 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zachschuermann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
nicklan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
resolves #876
We have no use for the counters in
CheckpointVisitor:file_actions&non_file_actions. We combine the two downstream to retrieve the totalactions_countwhen writing last_checkpoint.