Skip to content

Conversation

@sebastiantia
Copy link
Collaborator

@sebastiantia sebastiantia commented Apr 23, 2025

resolves #876

We have no use for the counters in CheckpointVisitor: file_actions & non_file_actions. We combine the two downstream to retrieve the total actions_count when writing last_checkpoint.

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.11%. Comparing base (399baf5) to head (e35f4f1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/checkpoint/log_replay.rs 88.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
- Coverage   85.11%   85.11%   -0.01%     
==========================================
  Files          87       87              
  Lines       21874    21865       -9     
  Branches    21874    21865       -9     
==========================================
- Hits        18619    18610       -9     
  Misses       2298     2298              
  Partials      957      957              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the breaking-change Change that require a major version bump label Apr 23, 2025
@sebastiantia sebastiantia marked this pull request as ready for review April 30, 2025 02:57
@sebastiantia sebastiantia removed the breaking-change Change that require a major version bump label Apr 30, 2025
Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sebastiantia sebastiantia merged commit 630cce8 into delta-io:main May 7, 2025
21 checks passed
@sebastiantia sebastiantia deleted the combine-actions-counters branch May 7, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combinefile_actions & non_file_actions into actions_count

3 participants