[wip] split out default engine into separate crate #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
zachschuermann
force-pushed
the
crate-split-redo
branch
from
fb2af14 to
f4c6a29
Compare
zachschuermann
force-pushed
the
crate-split-redo
branch
from
f4c6a29 to
eb2260c
Compare
zachschuermann
force-pushed
the
crate-split-redo
branch
from
eb2260c to
3982de5
Compare
zachschuermann
added a commit
that referenced
this pull request
May 24, 2025
…e else (#957) ## What changes are proposed in this pull request? Again prompted by the crate split exploration (#941). Notice that the `SyncEngine` is not really useful to external users, instead just adding to our public API and complicating our feature flags. We expect users to reach for the default engine in the case they want a 'prebuilt' solution with minimal deps and sane defaults (arrow, tokio). The `SyncEngine` will continue to exist as a test-only engine (for now; and will maybe evolve in the future). This PR includes 1. removing `sync-engine` feature flag (in core kernel and FFI), and making the existing `engine::sync` module `#[cfg(test)]` 2. removing any consumption of the sync engine in (1) examples and (2) integration tests 3. adding a simple test_util trait `DefaultEngineExtension ` and a simple method to return a new local default engine (to more easily mimic SyncEngine API for easy replacement) ### This PR affects the following public APIs - no more `SyncEngine`, no more `sync-engine` feature flag ## How was this change tested? Existing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Splitting out the default engine into a separate crate. This highlighted a number of places where the default engine is tightly coupled with the kernel: namely, violating orphan rule, conflating Error types, using private types.
TODO: list major components
Follow-ups
Future work
TODO
This PR affects the following public APIs
Lots, TODO
How was this change tested?
rely on existing