refactor!: remove Table APIs #976
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
zachschuermann
force-pushed
the
remove-table
branch
from
1a56e00 to
939af20
Compare
…_uri and Snapshot::transaction
zachschuermann
force-pushed
the
remove-table
branch
from
939af20 to
2494b63
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
==========================================
- Coverage 85.07% 85.07% -0.01%
==========================================
Files 90 89 -1
Lines 23395 23358 -37
Branches 23395 23358 -37
==========================================
- Hits 19904 19871 -33
+ Misses 2479 2474 -5
- Partials 1012 1013 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scovich
reviewed
May 27, 2025
| let (latest, versions) = self.versions().await?; | ||
|
|
||
| let snapshot = table.snapshot(engine, None)?; | ||
| let snapshot = Snapshot::try_new(self.table_root()?, engine, None)?; |
There was a problem hiding this comment.
Aside: a quick skim of the code suggests we have no consistency about whether engine is first arg or not. Should we care?
Comment on lines
-406
to
-407
| let table = Table::try_from_uri(path)?; | ||
| Ok(table.location().clone()) |
| HashMap::<String, String>::new(), | ||
| Arc::new(TokioBackgroundExecutor::new()), | ||
| )?; | ||
|
|
||
| let snapshot = table.snapshot(&engine, None)?; | ||
| let snapshot = Snapshot::try_new(url, &engine, None)?; | ||
| println!("Reading {}", snapshot.table_root()); |
| //! The entry-points for this API are: | ||
| //! 1. [`Snapshot::checkpoint`] | ||
| //! 2. [`Table::checkpoint`] | ||
| //! The entrypoint for this API is [`Snapshot::checkpoint`]. |
There was a problem hiding this comment.
Suggested change
| //! The entrypoint for this API is [`Snapshot::checkpoint`]. | |
| //! The entry point for this API is [`Snapshot::checkpoint`]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Prefactor PR for upcoming CatalogManaged/ResolvedTable work. The 'Table' API was just a think shell around a Url - only meaningful work that was done was in the
try_from_urimethod. All other methods now are just called directly on snapshot. Specifically, this PRTableAPIs (Table struct, methods, etc.)delta_kernel::try_parse_uri(&str) -> Url)Snapshot::try_from_uriandSnapshot::transactionHow was this change tested?
existing tests modified to use new APIs