fix: make DeltaTable pickleable #3501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
HiromuHota
changed the title
HiromuHota
changed the title
There was a problem hiding this comment.
Perhaps using a flag to track if storage options were explicitly passed, and only pickling them if they were would be a more security conscious implementation here?
It avoids credentials being unexpectedly dumped from the environment, but allows credentials to be portable if users pass them explicitly.
| @@ -158,6 +158,8 @@ def __init__( | |||
|
|
|||
| """ | |||
| self._storage_options = storage_options | |||
There was a problem hiding this comment.
Suggested change
| self._storage_options = storage_options | |
| self._storage_options = storage_options | |
| self._pickle_storage_options = storage_options is not None |
|
I suggest you create a wrapper (dask-contrib/dask-deltatable#87 (comment)) after #3518 lands :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
__reduce__method to DeltaTable to make an object of this class pickleable.Related Issue(s)
This will fix dask-contrib/dask-deltatable#87 and potentially other distributed system that have to serialize a DeltaTable object and send it over to workers.
Documentation
N/A