Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK] Add exclusion for integral types check in SchemaUtils.normalizeColumnNamesInDataType #2760

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

ala
Copy link
Contributor

@ala ala commented Mar 18, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

The check was too restrictive and was logging false-positives.

How was this patch tested?

Updated tests in SchemaUtilsSuite.

Does this PR introduce any user-facing changes?

No.

@ala ala changed the title [SPARK] Add exclusion for numeric types check in SchemaUtils.normalizeColumnNamesInDataType [SPARK] Add exclusion for integral types check in SchemaUtils.normalizeColumnNamesInDataType Mar 18, 2024
Copy link
Contributor

@larsk-db larsk-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkorukanti vkorukanti merged commit 6ccbabb into delta-io:master Mar 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants