[Spark] Validate computed state against checksum on checkpoint #3846
+381
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+611
to
+613
| if (spark.conf.get(DeltaSQLConf.DELTA_WRITE_CHECKSUM_ENABLED)) { | ||
| snapshot.validateChecksum(Map("context" -> "writeCheckpoint")) | ||
| } |
There was a problem hiding this comment.
@scovich @dhruvarya-db Should this check be done in the beginning or in the end of writing checkpoint?
There was a problem hiding this comment.
I feel that it would be a waste of time to write a checkpoint only to find out that there is something wrong with the delta log.
There was a problem hiding this comment.
@prakharjain09 Since most of this PR is about the validation logic itself, maybe we can address the question of when validation should be triggered in a follow up?
dhruvarya-db
force-pushed
the
checksum-validation-1
branch
from
59e7365
to
284427c
Compare
prakharjain09
approved these changes
Nov 6, 2024
dhruvarya-db
force-pushed
the
checksum-validation-1
branch
from
284427c
to
30b4ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Follow up for #3828.
This PR adds checksum validation logic. On every checkpoint, we will take the computed state of the table as per the deltas and the previous checkpoint and compare it against the checksum that was written at that version. The same methods can potentially be used to validate more frequently (if needed).
How was this patch tested?
Added a new test case in ChecksumSuite that tests that all logically corrupted fields are being caught by the validation logic.
Does this PR introduce any user-facing changes?
No