Allow CREATE OR REPLACE with CatalogManaged if not changing commit coordinator #5889
Conversation
tdas
left a comment
tdas
left a comment
There was a problem hiding this comment.
there does not seem to any unit tests. can we add a unit tests to ensure that this actually works?
for example, we now have full end-to-end UC tests using the UC server running in the JVM - https://github.com/delta-io/delta/tree/master/spark/unitycatalog/src/test/java/io/sparkuctest
can you make sure that there is test coverage here that ensures that this works end to end?
|
|
||
| // Allow specifying CatalogManaged in REPLACE TABLE if the existing table is already | ||
| // CatalogManaged. In this case, the commit coordinator properties are treated as a no-op. | ||
| // Block if trying to enable CatalogManaged on a non-CatalogManaged table via REPLACE. |
There was a problem hiding this comment.
Hi @xzhseh , seems like you are adding an enforced checking to prevent REPLACE an existing non-catalogManaged table to be a managed one.
I will suggest to add an integration tests to cover the changes you made. https://github.com/delta-io/delta/blob/master/spark/unitycatalog/src/test/java/io/sparkuctest/UCDeltaTableCreationTest.java
4 participants
Which Delta project/connector is this regarding?
Description
As titled.
How was this patch tested?
UTs.
Does this PR introduce any user-facing changes?
Yes.