[Kernel] Add basic support for checkpointProtection by throwing exception on checkpoint
#5917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
397
to
403
| spark.sql(s"CREATE TABLE delta.`$tablePath` (id INT) USING delta " + | ||
| "TBLPROPERTIES ('delta.feature.checkpointProtection' = 'supported')") | ||
|
|
||
| // Add some data to create commits | ||
| for (_ <- 0 to 3) { | ||
| spark.sql(s"INSERT INTO delta.`$tablePath` VALUES (1), (2), (3)") | ||
| } |
Collaborator
There was a problem hiding this comment.
do you need to use delta-spark? Couldn't you use kernel to create the table? and look at other tests for how we append/insert data?
| val ex = intercept[Exception] { | ||
| kernelCheckpoint(tc, tablePath, checkpointVersion = 4) | ||
| } | ||
| assert(ex.getMessage.contains("checkpointProtection")) |
Collaborator
There was a problem hiding this comment.
Assert more of the error message please. this makes reading this single test even cleaner.
Collaborator
scottsand-db
left a comment
scottsand-db
left a comment
There was a problem hiding this comment.
Awesome! Nice and short and simple. Thank you! A few comments on the test -- After those are addressed, will stamp 🚀
dengsh12
changed the title
checkpointProtectioncheckpointProtection by throwing exception on checkpoint
Collaborator
Author
Thanks for the suggestions, really good points! Fixed the test, still pending the discussion about a corner case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add basic support for
checkpointProtectiontable feature in Kernel. When a table hascheckpointProtectionenabled, Kernel throws an exception when attempting to checkpoint.How was this patch tested?
Added tests
Does this PR introduce any user-facing changes?
No