Skip to content

[Spark][REFACTOR][TEST-ONLY] Move test from DeltaRetentionSuiteBase to DeltaRetentionSuite #5921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c27kwan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Spark][REFACTOR][TEST-ONLY] Move test from DeltaRetentionSuiteBase to DeltaRetentionSuite #5921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
913a3e4
[Spark][REFACTOR][TEST-ONLY] Move test from DeltaRetentionSuiteBase t…
c27kwan Jan 23, 2026
90ca7d3
Merge branch 'master' into move-test-from-retentionsuitebase
OussamaSaoudi Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions spark/src/test/scala/org/apache/spark/sql/delta/DeltaRetentionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@ class DeltaRetentionSuite extends QueryTest
getDeltaFiles(dir) ++ getUnbackfilledDeltaFiles(dir) ++ getCheckpointFiles(dir)++
getCrcFiles(dir)

test("startTxnWithManualLogCleanup") {
withTempDir { tempDir =>
val log = DeltaLog.forTable(spark, new Path(tempDir.getCanonicalPath))
startTxnWithManualLogCleanup(log).commit(Nil, testOp)
assert(!log.enableExpiredLogCleanup())
}
}

test("delete expired logs") {
withTempDir { tempDir =>
val startTime = getStartTimeForRetentionTest
Expand Down
8 changes: 0 additions & 8 deletions spark/src/test/scala/org/apache/spark/sql/delta/DeltaRetentionSuiteBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,4 @@ trait DeltaRetentionSuiteBase extends QueryTest
txn.updateMetadata(Metadata())
txn
}

test("startTxnWithManualLogCleanup") {
withTempDir { tempDir =>
val log = DeltaLog.forTable(spark, new Path(tempDir.getCanonicalPath))
startTxnWithManualLogCleanup(log).commit(Nil, testOp)
assert(!log.enableExpiredLogCleanup())
}
}
}
Loading