[Spark] Use the common TableSetup to build the create table SQL clause. #5923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
We introduced a general
TableSetupclass to unify all the places to generate the create table sql, so that all the places can have the same semantic.This is mainly used for addressing the spark unitycatalog integration test. As in future, we will add more test coverage such as
VARIANT,generated columns,SHALLOW CLONEetc. The unification will help us to be more easiler to design the test coverage.How was this patch tested?
Locally test and remote test.
Does this PR introduce any user-facing changes?
No.