[Kernel] Fix long overflow when parsing far-future timestamp stats #5927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChronoUnit.MICROS.between() internally computes (seconds * 1_000_000_000) / 1000, where the intermediate nanoseconds value overflows for timestamps beyond ~292 years from epoch. Fix by computing seconds * 1_000_000 directly. Co-Authored-By: Claude Opus 4.5 <[email protected]>
huan233usc
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
ChronoUnit.MICROS.between() internally computes (seconds * 1_000_000_000) / 1000,
where the intermediate nanoseconds value overflows for timestamps beyond ~292
years from epoch. Fix by computing seconds * 1_000_000 directly.
How was this patch tested?
New UTs.
Does this PR introduce any user-facing changes?
No