Use astro orbit #574
Closed
Use astro orbit #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for deltaio-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
01001101CK
force-pushed
the
use-astro-orbit
branch
from
37c21b0 to
1c46b59
Compare
…e scripts/styles and external resources - Updated theme configuration to import astro-orbit/theme.css, added Delta Lake branding overrides via @theme block, and moved @Utility directives to main theme.css for Tailwind v4 processing. - Fixed LakeSection component to use getImage from astro:assets for proper background image processing - Resolved styling issues by ensuring CSS variables and utility classes are processed correctly Signed-off-by: Yufa <112290188+01001101CK@users.noreply.github.com>
- Completed migration, removed lib/delta-theme, fixed all styling issues Signed-off-by: Yufa <112290188+01001101CK@users.noreply.github.com>
- Wraps astro-orbit Section component to maintain backward compatibility - Adds support for title, titleSize, isHeaderCentered props - Supports before-header and subtitle slots - Forwards all other props (padding, className, etc.) to astro-orbit Section Signed-off-by: Yufa <112290188+01001101CK@users.noreply.github.com>
- If still "loading" → wait for DOMContentLoaded - If already "complete" or "interactive" → initialize immediately Signed-off-by: Yufa <112290188+01001101CK@users.noreply.github.com>
01001101CK
force-pushed
the
use-astro-orbit
branch
from
6fd30bf to
61494cc
Compare
Signed-off-by: Yufa <112290188+01001101CK@users.noreply.github.com>
Signed-off-by: Yufa <112290188+01001101CK@users.noreply.github.com>
Collaborator
jakebellacera
left a comment
jakebellacera
left a comment
There was a problem hiding this comment.
Initial feedback.
Also, I didn't see the _headers changes. Did those not come through?
Comment on lines
-60
to
+72
| a, | ||
| button { | ||
| /* Use :global() to make styles global so they override astro-orbit's button styles */ | ||
| :global(a.variant-primary), | ||
| :global(button.variant-primary), | ||
| :global(a.variant-secondary), | ||
| :global(button.variant-secondary), | ||
| :global(a.variant-accent), | ||
| :global(button.variant-accent), | ||
| :global(a.variant-more), | ||
| :global(button.variant-more), | ||
| :global(a.button-size-sm), | ||
| :global(button.button-size-sm), | ||
| :global(a.button-size-md), | ||
| :global(button.button-size-md) { |
Collaborator
There was a problem hiding this comment.
This is a smell.
Rather than moving the components around in this project, why not merge what we have into astro-orbit? Ideally everything in lib/delta-theme (now src/components/ui) should be moved into astro-orbit, and all we should be left with are a few necessary components to build the pages which extend astro-orbit stuff. Then we shouldn't need to worry so much about specificity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
<Section>wrapper component to extend astro-orbit Section with title, titleSize, isHeaderCentered props, and before-header/subtitle slots.Corresponding Ticket:
db-os-dev #22