Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Back up Chats to External Storage" to "Export Backup" #3416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Nov 7, 2024

A backup contains more than just the chats, and it's not true that the backup will be exported to "external storage". (the backup will be exported to the Downloads folder, which may well be on the internal storage rather than the SD card).

Old/New:

image

image

@Hocuri Hocuri requested review from r10s and adbenitez November 7, 2024 15:20
@adbenitez
Copy link
Member

adbenitez commented Nov 7, 2024

some user already reported in the past that they didn't realize this was the option to export the whole profile

wondering if there is a better naming that could transmit the idea "this backups your whole profile" or maybe take the opportunity to add something like that as explanation subtitle!

see ArcaneChat#33

Copy link

github-actions bot commented Nov 7, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s
Copy link
Member

r10s commented Nov 7, 2024

some user already reported in the past that they didn't realize this was the option to export the whole profile

let's see after things change i'd say.

the new wording (that is also used on desktop/iOS) does not limit things to "chats", so, a simple "export" indeed might work much better than "export chats"

also, if you tap the option, you already now get some details about what is exported

@Hocuri Hocuri added the PR waiting for merge window potentially dangerous or otherwise unfitting PR waiting for better merge timing label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR waiting for merge window potentially dangerous or otherwise unfitting PR waiting for better merge timing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants