Skip to content

Show channels in a proper "Channel" chat #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: adb/pgp-contacts2
Choose a base branch
from

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Jun 4, 2025

Depends on chatmail/core#6901 but can already be reviewed, part of chatmail/core#6884

  • Rename "broadcast list" to "channel" or "broadcast channel" both in UI and code (depending on whether it's important to be concise in the particular place). There are new stock strings in which broadcast_list is replaced with channel
  • Adapt to the new chat types InBroadcastChannel and OutBroadcastChannel for incoming / outgoing channels, where the former is similar to a Mailinglist and the latter is similar to a Broadcast (which was removed)
  • Adapt to the new create_broadcast_channel() API
  • Wait for a core release with feat: Show broadcast channels in their own, proper "Channel" chat chatmail/core#6901

Copy link

github-actions bot commented Jun 4, 2025

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@Hocuri Hocuri requested review from adbenitez and r10s June 23, 2025 13:48
@Hocuri Hocuri changed the title [WIP] Rename "broadcast list" to "channel"/"broadcast channel" both in UI and code Show channels in a proper "Channel" chat Jun 23, 2025
@Hocuri Hocuri changed the base branch from adb/pgp-contacts to adb/pgp-contacts2 June 30, 2025 16:35
@Hocuri
Copy link
Collaborator Author

Hocuri commented Jun 30, 2025

Also here, I renamed BroadcastChannel to Broadcast to match core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants